Add support for trusted user CA keys and authorized principals in OpenSSH config#92
Add support for trusted user CA keys and authorized principals in OpenSSH config#92tg123 wants to merge 5 commits intolinuxserver:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
Thanks for the PR, but this is way too many env vars added for such a niche feature. Users can easily add this manually as all the necessary files reside in the bind mounted config folder. Each new env var added increases the setup complexity and thus the barrier of entry, and significantly increases the support burden for our team. I'm afraid this PR has a too high cost to benefit ratio. |
|
all _FILE and ADD_DEFAULT can be removed what about adding 2 env? |
|
I am a bot, here are the test results for this PR:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is locked due to inactivity |
3 participants
Description:
Add support for trusted user CA keys and authorized principals in OpenSSH config
Benefits of this PR and context:
Add new secure way for ssh keys using CA
How Has This Been Tested?
YES
tested locally
Source / References: